Next

Program Repair Shop

26

CopyFiles

• We are now going to beat this function to death

• First, notice that $Tmp is useless

         $Tmp = `cp $x1 $x2`;

• $Tmp contains the output of the cp command

• The cp command does not produce any output

• What is $Tmp there for then?

• I have no idea

  • (I thought it might be to stop a useless use...in void context warning, but it's not)

• Let's get rid of $Tmp:

         `cp $x1 $x2`;

• Better is just:

        system("cp $x1 $x2");

• Say what you Mean

Next

Copyright © 2002 M. J. Dominus