Next

Program Repair Shop

27

CopyFiles

      56        $x1 = $dir.$file;
      57        $x2 = $dir.$NextOut."/".$file;

• Believe it or not, the concatenation operator (.) is a red flag

• Use Interpolation Instead of Operators

• Why? Because interpolation makes the code look like the string it will generate

• There is less to be filtered out by the eye

                $x1 = "$dir/$file";
                $x2 = "$dir/$NextOut/$file";

• This is the other reason I trimmed the trailing slashes from @InputDIR

• Without the trimming, we would have had:

                $x1 = "$dir$file";
                $x2 = "$dir$NextOut/$file";

• These are less clear

Next

Copyright © 2002 M. J. Dominus