Declarations

     473  sub compare_by_first_block
     474  {
     475      my ($readsize) = shift (@_);
     476      my (@filenames) = @_;
     477

• I suggest:

        sub compare_by_first_block
        {
          my ($readsize, @filenames) = @_;

• Declarations carry very little information

• It's easy to write a ton of them

• This function starts with 20(!) lines of stuff that is not code

Next

Copyright © 2006 M. J. Dominus