Unnecessary variables

• And similarly:

      sub FindUXml
      {
              my $queryCallsign = shift;
              my %aprsInfo = FindU($queryCallsign);
              my $xmlTree = CreateStationXml(%aprsInfo)->as_XML;
              return $xmlTree;
      }

• Perhaps:

      sub FindUXml
      {
              my $queryCallsign = shift;
              return CreateStationXml(FindU($queryCallsign))->as_XML;
      }

• We could get rid of $queryCallsign too:

      sub FindUXml
      {
              return CreateStationXml(FindU(shift))->as_XML;
      }

• What do you think?

Next

Copyright © 2006 M. J. Dominus