Next

Program Repair Shop

232

Arbitrary Numeric Constants

• Sometimes they are warranted

     my $ltime = localtime($d * 86400);  # Number of seconds in a day

     print STDERR "Analyzed $i words.\n" if $DEBUG && $i++ % 1000 == 0;

     # 12 months in a year
     %m2n = map {$mon[$_] => $_} (0..11);

• But they almost always should be accompanied by a comment

• Perhaps that last example should have said

        %m2n = map {$mon[$_] => $_} (0..$#mon);

Next

Copyright © 2002 M. J. Dominus