Program Repair Shop

Repeated Code Harbors Bugs

     Subject: routine on each value
     Message-ID: <u1v5l1cf8qtv26@corp.supernews.com>

     if($match) {
         (($rank = @ranks[0]) && ($percent = "1%")) if $value == 1;
         (($rank = @ranks[1]) && ($percent = "2%")) if $value == 2;
         (($rank = @ranks[2]) && ($percent = "3%")) if $value == 3;
         (($rank = @ranks[3]) && ($percent = "4%")) if $value == 4;
         (($rank = @ranks[4]) && ($percent = "5%")) if $value == 5;
         (($rank = @ranks[5]) && ($percent = "6%")) if $value == 6;
         (($rank = @ranks[5]) && ($percent = "7%")) if $value == 7;
         (($rank = @ranks[6]) && ($percent = "8%")) if $value == 8;
         (($rank = @ranks[7]) && ($percent = "9%")) if $value == 9;
         (($rank = @ranks[8]) && ($percent = "10%")) if $value == 10;

}

Several people 'corrected' this to:

     if ($match) {
       $rank = $ranks[$value-1];
       $percent = "$value%";
     }

Either the original code was broken, or the corrections were broken
Somewhere, there was a bug
Not a very impressive showing by the Perl community