Next

Program Repair Shop

46

Unnecessary Variables

            $I = mkdir($dir,0777);
            if ($I) {

• This is the only place $I is used

• Use immediately follows assignment

• Why bother to make a copy unless you are going to use it again?

  • (One possible answer: For documentative purposes)

• In this case, better is:

            if (mkdir($dir,0777)) {

Next

Copyright © 2002 M. J. Dominus