Program Repair Shop

Repeated expressions

        verbose "jsjvv: md5sum found " .
              scalar  (@{$file_name_by_md5sum{$md5sum}}) . " matches\n"
          if scalar  (@{$file_name_by_md5sum{$md5sum}}) > 1;

Since we're here, lets deal with this small mess
What's really wrong here is the repetition of the complex expression
In fact, the corruption is more widespread than that:

     644      foreach $md5sum (keys %file_name_by_md5sum)
     645      {
     646        push @md5_LoL , [ @{$file_name_by_md5sum{$md5sum}} ]
     647            if ( scalar  (@{$file_name_by_md5sum{$md5sum}}) > 1);
     648            # do NOT push single file lists, there's nothing to match!
     649  
     650  print STDERR "jsjvv: md5sum found " .
     651            scalar  (@{$file_name_by_md5sum{$md5sum}}) . " matches\n"
     652      if ($verbose1) && ( scalar  (@{$file_name_by_md5sum{$md5sum}}) > 1);

Of the visible characters in this code, 39% are in the repeated expression!