Program Repair Shop

Declarations

Speaking of ex-C-programmers, here's another example you folks sent:

      sub pre_process_file {

        my $dbh = shift;
        my $file = shift;
        my $provider_id = shift;
        my $prv = shift;

        my $sql;
        my $sth;
        my $cmd;

        my %mail;

        my $provider_name;
        my $provider;
        my $internal_file;
        my $file_type;
        my $raw_layout;
        my $incoming_layout;
        my $valid_layout;

        my $zip;
        my @zip_members;
        my $member;
        my $data_file;
        my $data_out_path;

        my $zip_file;   # input zip filename path information
        my $bad_file;   # bad records returned from sort
        my $dup_file;   # contains any duplicate records from exclude
        my $unq_file;   # contains unique records from exclude   
        my $inv_file;   # contains records with invalid phone numbers 
        my $good_file;  # contains records that are ready to be loaded
        my $in_file;    # basename of the input file

        my $num_in   = 0;
        my $num_bad  = 0;
        my $num_dupe = 0;
        my $num_good = 0;

        my $file_info_id;

        my @flds = qw(provider_name provider internal_file file_type raw_layout incoming_layout valid_layout);

        ($provider_name, $provider, $internal_file, 
         $file_type, $raw_layout, 
         $incoming_layout, $valid_layout) = @{$prv->{$provider_id}}{@flds};

        # If file is zipped, then unzip it
        if ($file =~ /\.zip$/i)

Wow!
- That's 42 lines of declarations